Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add UNIQUE data type #70

Merged
merged 4 commits into from
Aug 11, 2023
Merged

feat: Add UNIQUE data type #70

merged 4 commits into from
Aug 11, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

@mbelak-dtml mbelak-dtml commented Aug 9, 2023 •
edited
Loading

Resolves #33

@mbelak-dtml mbelak-dtml self-assigned this Aug 9, 2023
@mbelak-dtml mbelak-dtml force-pushed the feat/univariate-analysis-unique-data-type branch 2 times, most recently from 55d942e to 53e46fe Compare August 9, 2023 14:25
@mbelak-dtml mbelak-dtml mentioned this pull request Aug 9, 2023
Closed
@mbelak-dtml mbelak-dtml changed the title feat: Use UNIQUE data type in univariate analysis feat: Add UNIQUE data type Aug 9, 2023
@mbelak-dtml mbelak-dtml force-pushed the feat/univariate-analysis-unique-data-type branch from 53e46fe to 136ebb6 Compare August 10, 2023 07:43
@mbelak-dtml mbelak-dtml marked this pull request as ready for review August 10, 2023 07:43
@mbelak-dtml mbelak-dtml requested a review from lukany August 10, 2023 07:43
lukany
lukany approved these changes Aug 10, 2023
View reviewed changes
tests/test_data_type_inference.py Outdated Show resolved Hide resolved
edvart/report_sections/univariate_analysis.py Outdated Show resolved Hide resolved
lukany
lukany requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously approved by mistake

@mbelak-dtml mbelak-dtml requested a review from lukany August 11, 2023 07:12
lukany
lukany requested changes Aug 11, 2023
View reviewed changes
tests/test_data_type_inference.py Outdated Show resolved Hide resolved
@mbelak-dtml mbelak-dtml force-pushed the feat/univariate-analysis-unique-data-type branch from 136ebb6 to 765d714 Compare August 11, 2023 12:34
@mbelak-dtml
feat: Add UNIQUE data type.
11235ac 
The data type is used for non-numeric columns where each row has a different values, e.g. an ID etc.
@mbelak-dtml
feat: Use UNIQUE data type in univariate analysis
ba30079
@mbelak-dtml
test(review): Improve formatting
b5853eb
@mbelak-dtml mbelak-dtml force-pushed the feat/univariate-analysis-unique-data-type branch from 765d714 to b5853eb Compare August 11, 2023 12:38
@mbelak-dtml mbelak-dtml requested a review from lukany August 11, 2023 12:39
@lukany lukany added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit c5956ca Aug 11, 2023
@lukany lukany deleted the feat/univariate-analysis-unique-data-type branch August 11, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Unique" data type
2 participants
@mbelak-dtml @lukany