feat!: Refactor Report into Report and DefaultReport.
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbelak-dtml
force-pushed
the
refactor/default-report
branch
from
a11ca42 to
29f40fd
Compare
mbelak-dtml
changed the title
Report and DefaultReport.
mbelak-dtml
force-pushed
the
refactor/default-report
branch
2 times, most recently
from
8faa91e to
09d84f6
Compare
BREAKING CHANGE: * Most parameters of `Report` class have been removed. `Report` class now behaves as it would previously with `use_default_sections=False`. * Newly-added class `DefaultReport` now behaves as `Report` previously would with `use_default_sections=True`. * Most parameters of `TimeseriesReport` class have been removed. `DefaultTimeseriesReport` class now behaves as it would previously with `use_default_sections=False`. * Newly-added class `DefaultTimeseriesReport` now behaves as `TimeseriesReport` previously would with `use_default_sections=True`.
mbelak-dtml
force-pushed
the
refactor/default-report
branch
from
09d84f6 to
9d3dda1
Compare
mbelak-dtml
changed the title
Report and DefaultReport.Report into Report and DefaultReport.
lukany
requested changes
Aug 4, 2023
There was a problem hiding this comment.
- There is still mention about
use_default_sectionsargument in docs:Line 129 in 9d3dda1
- The PR should be IMO
feat!, notrefactor!. Theoratically, it doesn't add any new features but it technically it changes API of existing classes and adds new classes.
mbelak-dtml
changed the title
Report into Report and DefaultReport.Report into Report and DefaultReport.
Thanks, fixed.
I'm not sure what constitutes a |
lukany
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45