feat!: Remove utils.is_categorical
#108
Conversation
mbelak-dtml
force-pushed
the
feat/remove-utils-is-categorical
branch
2 times, most recently
from
fc601b1 to
2150e77
Compare
Preparatory commit for removal of `utils.is_categorical`. Slightly changes behavior of some plots, e.g. parallel categories is now stricter in choosing which columns are considered as categorical.
BREAKING CHANGE: function `edvart.utils.is_categorical` is removed. `edvart.data_types.is_categorical` can be used instead, with similar behavior. Resolves #25.
mbelak-dtml
force-pushed
the
feat/remove-utils-is-categorical
branch
from
2150e77 to
1633cc7
Compare
There was a problem hiding this comment.
I think that the change in the first commit: "parallel categories is now stricter in
choosing which columns are considered as categorical" is actually a breaking. It's not breaking API change but the behaviour of edvart is different. I'd mention it as a breaking change in PR description.
Also,
BREAKING CHANGE: function `edvart.utils.is_categorical` is removed. `edvart.data_types.is_categorical`
can be used instead, with similar behavior.
should be in PR description, otherwise it won't be in changelog
Yup, added both breaking changes to the PR description. |
Resolves #25
BREAKING CHANGE: function
edvart.utils.is_categoricalis removed.edvart.data_types.is_categoricalcan be used instead, with similar behavior.
BREAKING CHANGE: Slightly changes behavior of column selection for some plots, e.g. parallel categories is now stricter in choosing which columns are considered as categorical.