Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better cope with PowerShell sending a BOM (Windows), or stop trying #108

Open
nblumhardt opened this issue Apr 11, 2019 · 0 comments
Open

Better cope with PowerShell sending a BOM (Windows), or stop trying #108

nblumhardt opened this issue Apr 11, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@nblumhardt
Copy link
Member

Version 5.1.213 includes a small hack to try to get around encoding issues when running seqcli under PowerShell on Windows: https://github.com/datalust/seqcli/blob/dev/src/SeqCli/PlainText/Framing/FrameReader.cs#L39

Unfortunately, this is racy, and doesn't work all the time.

Our options are:

  • Dig deeper to figure out how it is that the BOM gets through, even with a UTF-8 encoding specified for STDIN
  • Try to skip the BOM in more places (when we read the first line in FrameReader
  • Stop trying

I think we're better off giving up; PowerShell Core no longer has this issue (verified with 6.2), so it's a point-in-time thing anyway.
@nblumhardt nblumhardt added the enhancement New feature or request label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nblumhardt