Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch hangovers #180

Closed
da5nsy opened this issue Jul 23, 2023 · 3 comments
Closed

master branch hangovers #180

da5nsy opened this issue Jul 23, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@da5nsy
Copy link
Contributor

da5nsy commented Jul 23, 2023

Describe the bug
There are a few places in this repo that still point to the master branch (which I think has been renamed main).
I noticed this while browsing https://docs.datalad.org/projects/osf/en/latest/index.html - all the "edit" buttons still point to the master branch.

Suggested action
I could guess which of these need updating, but it seems wise to leave it to someone who knows the repo better 😅

@da5nsy da5nsy added the bug Something isn't working label Jul 23, 2023
@adswa
Copy link
Member

adswa commented Jul 24, 2023

uhh, this is a very good catch, thank you! You're right that the repo's default branch was renamed (we're slow with doing this for all the older repos, but we're getting there...), and I, too, believe this is some not-yet-noticed fallout of this. But I think none of the occurrences of master that you linked are to blame here (though some need fixing, I'll take care). I rather think the automatic configuration on readthedocs.org failed, and it pointed latest to master, even though we configured main to be the default branch. I have updated the config, and after many hard-refreshs of my browser the Edit button took me to the main branch - phew, and thanks again!

@adswa adswa closed this as completed Jul 24, 2023
@adswa
Copy link
Member

adswa commented Jul 24, 2023

hey @all-contributors please add @da5nsy for bug

@allcontributors
Copy link
Contributor

@adswa

I've put up a pull request to add @da5nsy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants