Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL to groups (with special characters) not correctly formed #6511

Closed
xiphl opened this issue Nov 22, 2022 · 2 comments
Closed

URL to groups (with special characters) not correctly formed #6511

xiphl opened this issue Nov 22, 2022 · 2 comments
Assignees
Labels
bug Bug report product PR or Issue related to the DataHub UI/UX

Comments

@xiphl
Copy link
Contributor

xiphl commented Nov 22, 2022

I have groups retrieved from OIDC with names that start with "/", ie "/something/something1/something2". When adding the group to an asset via UI, the URL that links back to the group is incorrect, ie urn:li:corpGroup/something/something1/something2 and it results in error page instead.

To Reproduce in demo site
Steps to reproduce the behavior:

  1. create a new group via UI that starts with "/" in name and urn
  2. attach group to a dataset
  3. click on group from dataset page
  4. encounter error
  5. click on the newly created group from "groups" page - the link works fine.

Additional context
Add any other context about the problem here.

@xiphl xiphl added the bug Bug report label Nov 22, 2022
@xiphl
Copy link
Contributor Author

xiphl commented Nov 22, 2022

the line responsible for creating the hyperlink in dataset ownership view:

<Link to={`/${entityRegistry.getPathName(owner.owner.type)}/${owner.owner.urn}`}>

whereas the url in groups overview was formed by:

<Link to={entityRegistry.getEntityUrl(EntityType.CorpGroup, item.urn)}>
is properly encoded

@laulpogan laulpogan added the product PR or Issue related to the DataHub UI/UX label Dec 7, 2022
@aditya-radhakrishnan aditya-radhakrishnan self-assigned this Dec 20, 2022
@aditya-radhakrishnan
Copy link
Contributor

Thanks for reporting this @xiphl ! This has been solved with this PR being merged #6814

Really appreciate you noticing this bug and posting it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

No branches or pull requests

3 participants