Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookml ingestion broken for cascading derived tables #3260

Closed
remisalmon opened this issue Sep 17, 2021 · 2 comments · Fixed by #3262
Closed

lookml ingestion broken for cascading derived tables #3260

remisalmon opened this issue Sep 17, 2021 · 2 comments · Fixed by #3262
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. bug Bug report

Comments

@remisalmon
Copy link
Contributor

Describe the bug
Cascading derived tables are no longer ingested properly in DataHub.

When cascading derived tables are used in lookml views (see https://docs.looker.com/data-modeling/learning-lookml/derived-tables#cascading_derived_tables), they now get ingested as datasets from the upstream platform/connection instead of views from the same platform (looker).

This bug was introduced here in lookml.py: https://github.com/linkedin/datahub/pull/3255/files#diff-49de7c0eb38108e88215470de34a7d77a8d4ca25878877a2670e55864532341eL546-R683

To Reproduce
Steps to reproduce the behavior:

  1. Define a lookml view using cascading derived tables (i.e. refer a table defined in another view)
  2. Ingest lookml
  3. The lineage tab of the UI shows the wrong upstream platform

Expected behavior
The proper upstream platform (in this case the same platform, looker) should be shown.

Additional context
DataHub version: 0.8.13
acryl-datahub version: 0.8.13.1

@remisalmon remisalmon added the bug Bug report label Sep 17, 2021
@shirshanka shirshanka added the accepted An Issue that is confirmed as a bug by the DataHub Maintainers. label Sep 18, 2021
@shirshanka
Copy link
Contributor

@remisalmon: could you verify if #3262 fixes the issue for you?

@remisalmon
Copy link
Contributor Author

It does, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants