Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neo4jGraphSearch mixes up "null" with null entity type #3121

Closed
EnricoMi opened this issue Aug 19, 2021 · 2 comments
Closed

Neo4jGraphSearch mixes up "null" with null entity type #3121

EnricoMi opened this issue Aug 19, 2021 · 2 comments
Labels
bug Bug report devops PR or Issue related to DataHub backend & deployment pending-submitter-response Issue/request has been reviewed but requires a response from the submitter

Comments

@EnricoMi
Copy link
Contributor

The findRelatedEntities method of the Neo4J implementation of GraphService interprets a source or destination type "null" as the null value, which means any type. With "null" you restrict the result to only get entities related to / of type "null", not any.

There are tests in #3011 that test this behaviour.
@EnricoMi EnricoMi added the bug Bug report label Aug 19, 2021
@EnricoMi EnricoMi mentioned this issue Aug 19, 2021
Merged
@anshbansal
Copy link
Collaborator

Is this still an issue? If not, will close it in a few days due to inactivity.

@anshbansal anshbansal added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter devops PR or Issue related to DataHub backend & deployment labels Jul 25, 2022
@anshbansal
Copy link
Collaborator

Closing as no response in a while and I believe the PR deals with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug report devops PR or Issue related to DataHub backend & deployment pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anshbansal @EnricoMi