Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticSearchGraphService should work with no relationship types #3117

Closed
EnricoMi opened this issue Aug 19, 2021 · 1 comment
Closed

ElasticSearchGraphService should work with no relationship types #3117

EnricoMi opened this issue Aug 19, 2021 · 1 comment
Labels
feature-request Request for a new feature to be added

Comments

@EnricoMi
Copy link
Contributor

EnricoMi commented Aug 19, 2021

The GraphService API provides two methods findRelatedEntities and removeEdgesFromNode that allow to provide a list of relationship types. When that list is empty, the methods should no-op and return immediately.

The current ElasticSearch implementation does not show this behaviour.

There are tests in #3011 that test this behaviour.

@EnricoMi EnricoMi added the feature-request Request for a new feature to be added label Aug 19, 2021
@maggiehays
Copy link
Collaborator

Hi @EnricoMi!

We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. If this request is still relevant, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.

We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature to be added
Projects
None yet
Development

No branches or pull requests

3 participants