Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the security of the kubernetes/helm charts #1747

Closed
shakti-garg-saxo opened this issue Jul 24, 2020 · 6 comments · Fixed by #1782
Closed

Improve the security of the kubernetes/helm charts #1747

shakti-garg-saxo opened this issue Jul 24, 2020 · 6 comments · Fixed by #1782
Assignees
Labels
feature-request Request for a new feature to be added

Comments

@shakti-garg-saxo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We are trying to use helm charts in contrib module. First, deployment in dev failed due to some hardcodings. In the meantime, we also discovered it having some security vulnerabilities like passwords being passed in "verbatim", etc

Describe the solution you'd like
Secure and automated deployment of helm charts

Describe alternatives you've considered

  1. move the password parameters from verbatim mode to kube-secrets
  2. use configmaps to discover service configurations for easy deployment
  3. initcontainer for initializing the mysql schema
  4. remove hard-coded references like "datahub-gms-deployment-configmap"
  5. refactorings for ex, removal of obsolete code like contrib/kubernetes/yaml
@shakti-garg-saxo shakti-garg-saxo added the feature-request Request for a new feature to be added label Jul 24, 2020
@mars-lan
Copy link
Contributor

@bharatak could you help fix these issues?

@mars-lan
Copy link
Contributor

Sorry some confusions here. @shakti-garg-saxo will be working on a PR for this.

@jsotelo
Copy link
Contributor

jsotelo commented Jul 29, 2020

@shakti-garg-saxo Are you planning on including support for creating RBAC resources too? For example:

rbac:
  # Specifies whether RBAC resources should be created
  create: true

@shakti-garg-saxo
Copy link
Contributor Author

shakti-garg-saxo commented Jul 30, 2020

@jsotelo We are currently not trying to create service account as part of helm chart. We are going with assumption that serviceaccount (roles, clusterRole, etc) is pre-configured and is a parameter to LDH charts.

@mars-lan
Copy link
Contributor

@shakti-garg-saxo do you plan to re-use this issue for further security improvements? If not please feel free to close it.

@shakti-garg-saxo
Copy link
Contributor Author

We have achieved the objectives of this issue. So, IMO we can close it.

@mars-lan mars-lan reopened this Nov 3, 2020
@mars-lan mars-lan linked a pull request Nov 3, 2020 that will close this issue
4 tasks
@mars-lan mars-lan closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants