Relax check on patch_bits overflows in delta decoding
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, some files written with pyorc have a `patch_bit_width` larger than needing, causing the previous check to fail, even when decoding to `u64`. This changes the check to only fail when the patch bits actually overflow, instead of checking whether they may overflow. Closes datafusion-contrib#97
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 77.22% 84.27% +7.04%
==========================================
Files 34 36 +2
Lines 3302 3898 +596
==========================================
+ Hits 2550 3285 +735
+ Misses 752 613 -139 |
waynexia
pushed a commit
that referenced
this pull request
Oct 24, 2024
For some reason, some files written with pyorc have a `patch_bit_width` larger than needing, causing the previous check to fail, even when decoding to `u64`. This changes the check to only fail when the patch bits actually overflow, instead of checking whether they may overflow. Closes #97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, some files written with pyorc have a
patch_bit_widthlarger than needing, causing the previous check to fail, even when decoding tou64.This changes the check to only fail when the patch bits actually overflow, instead of checking whether they may overflow.
Unfortunately, I can't provide a test. Even when writing the exact same values with the same version of pyorc, the generated file does not trigger the error like https://softwareheritage.s3.amazonaws.com/graph/2024-05-16/orc/revision/revision-0c45576a-59f7-48d1-a9a8-2e5c64098905.orc
Closes #97