Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CI tools #3

Open
uilianries opened this issue Apr 5, 2018 · 9 comments
Open

Include CI tools #3

uilianries opened this issue Apr 5, 2018 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@uilianries
Copy link

Hi!

Thanks to push this great project into Github.

I would like to include some CI tools (e.g. Travis, Circle CI) to validate code warnings and compiler errors.

WDYT?

@e-witter e-witter self-assigned this Apr 5, 2018
@e-witter
Copy link

e-witter commented Apr 5, 2018

Great, I'll do it soon.

@evedovelli
Copy link
Collaborator

No problem at all. Indeed, it is a desired enhancement.

@evedovelli evedovelli added the enhancement New feature or request label Apr 5, 2018
@henriquenj
Copy link
Collaborator

IMHO we should aim to test within a Ubuntu 14.04 VM first (which travis provide it for us) since this OS is the one we know it works. We can then gradually add more jobs for newer versions of Ubuntu and other distros as a second step.

@uilianries
Copy link
Author

I use a large number of docker images to distribute Conan packages, including clang and gcc. All images are based on Ubuntu, but only few images are based on 14.04.
Also, there are official images for gcc and clang on hub.docker
I'm just saying that is not necessary to create a new docker image to build the project.

@henriquenj
Copy link
Collaborator

I'm not suggesting we generate our own docker image, or any image. I'm suggesting that we use Ubuntu 14.04 as a starting point, using the standard image provided by Travis.

@uilianries
Copy link
Author

The problem running on standard Travis image is that you are not "able" to reproduce the same environment on your side... So I commented about docker because the same docker image could be executed on both sides. But maybe you know some official image provided by Travis CI with cpp config on docker hub.

@henriquenj
Copy link
Collaborator

Fair point. I was indeed assuming I could download a standard Travis image and then just run it on my machine. If this is not true it will be a disadvantage of using Travis.

@uilianries
Copy link
Author

I found some tutorials running Travis over Docker, but I didn't try. Anyway, Travis might be only the "engine" to run all jobs. Run docker over Travis is pretty easy: https://docs.travis-ci.com/user/docker/

@henriquenj
Copy link
Collaborator

henriquenj commented Apr 5, 2018

Nice finding, thanks.

I'm not very concerned about using standard images just to compile l2tester (which I think it's the natural first step). Even if we can't run these images on a local machine, l2tester does not have a super elaborated build process. I'm more concerned when we attempt to run automated test, which I guess will involve some low level Linux manipulation, such as creating virtual Ethernet interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants