Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Crawl pipeline should check pipeline cluster config and cluster policy #844

Closed
1 task done
qziyuan opened this issue Jan 25, 2024 · 0 comments · Fixed by #864
Closed
1 task done

[FEATURE]: Crawl pipeline should check pipeline cluster config and cluster policy #844

qziyuan opened this issue Jan 25, 2024 · 0 comments · Fixed by #864
Labels
good first issue Good for newcomers step/assessment go/uc/upgrade - Assessment Step

Comments

@qziyuan
Copy link
Contributor

qziyuan commented Jan 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

Right now pipelines.py only check pipeline_response.spec.configuration, we should check pipeline_response.spec.clusters.spark_conf, pipeline_response.spec.clusters.init_scripts, pipeline_response.spec.clusters.policy_id

Proposed Solution

Do the same check as what jobs.py and clusters.py are doing.

Additional Context

No response
@qziyuan qziyuan added enhancement New feature or request needs-triage labels Jan 25, 2024
@qziyuan qziyuan added this to UCX Jan 25, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Jan 25, 2024
@pohlposition pohlposition added the step/assessment go/uc/upgrade - Assessment Step label Jan 29, 2024
@nfx nfx added good first issue Good for newcomers bug and removed needs-triage enhancement New feature or request labels Jan 30, 2024
@prajin-29 prajin-29 mentioned this issue Jan 31, 2024
Merged
11 tasks
This was referenced Feb 5, 2024
Closed
Closed
@nfx nfx closed this as completed in #864 Feb 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Archive in UCX Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers step/assessment go/uc/upgrade - Assessment Step
Projects
UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checking pipeline cluster config and cluster policy in 'crawl_pipelines' task databrickslabs/ucx
3 participants
@nfx @pohlposition @qziyuan