Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT]: Refactor verify_timeout property on DeployedWorkflows #2383

Closed
1 task done
asnare opened this issue Aug 7, 2024 · 0 comments · Fixed by #2547
Closed
1 task done

[TECH DEBT]: Refactor verify_timeout property on DeployedWorkflows #2383

asnare opened this issue Aug 7, 2024 · 0 comments · Fixed by #2547
Assignees
Labels
tech debt chores and design flaws

Comments

@asnare
Copy link
Contributor

asnare commented Aug 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

During #2364 we realised that the verify_timeout property on DeployedWorkflows should probably be refactored:

  • This is a configuration property that only relates to a (narrow) subset of the class functionality (calls to .repair_run()).
  • The caller to .repair_run() cares most about the timeout, not necessarily whoever is constructing the instance.
  • The timeout could vary per call.

Proposed Solution

Refactor so that the verify_timeout property is an argument on the .repair_run() method instead of being supplied via the instance initialiser.

Additional Context

The WorkflowsDeployment class in the same file also has a verify_timeout property that doesn't appear to be used anywhere. It can probably also be removed.

@asnare asnare added enhancement New feature or request needs-triage labels Aug 7, 2024
@asnare asnare added this to UCX Aug 7, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Aug 7, 2024
@asnare asnare removed the enhancement New feature or request label Aug 7, 2024
@JCZuurmond JCZuurmond added the tech debt chores and design flaws label Aug 7, 2024
@nfx nfx removed the needs-triage label Sep 3, 2024
@nfx nfx removed this from UCX Sep 3, 2024
@nfx nfx closed this as completed in #2547 Sep 10, 2024
@nfx nfx closed this as completed in 1bfca95 Sep 10, 2024
@pritishpai pritishpai self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt chores and design flaws
Projects
Development

Successfully merging a pull request may close this issue.

4 participants