From 9244a6517eac0c9d423fb5169118bc9318930fe3 Mon Sep 17 00:00:00 2001 From: Cor Zuurmond Date: Tue, 19 Nov 2024 11:50:26 +0100 Subject: [PATCH] Remove Dashboard.as_dict Handled in the SDK (https://github.com/databricks/databricks-sdk-py/releases/tag/v0.38.0) --- src/databricks/labs/lsql/dashboards.py | 4 ++-- tests/integration/test_dashboards.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/databricks/labs/lsql/dashboards.py b/src/databricks/labs/lsql/dashboards.py index 091f00bf..3222ed5b 100644 --- a/src/databricks/labs/lsql/dashboards.py +++ b/src/databricks/labs/lsql/dashboards.py @@ -1133,9 +1133,9 @@ def create_dashboard( warehouse_id=warehouse_id, ) if dashboard_id is not None: - sdk_dashboard = self._ws.lakeview.update(dashboard_id, dashboard=dashboard_to_create.as_dict()) # type: ignore + sdk_dashboard = self._ws.lakeview.update(dashboard_id, dashboard=dashboard_to_create) else: - sdk_dashboard = self._ws.lakeview.create(dashboard=dashboard_to_create.as_dict()) # type: ignore + sdk_dashboard = self._ws.lakeview.create(dashboard=dashboard_to_create) if publish: assert sdk_dashboard.dashboard_id is not None self._ws.lakeview.publish(sdk_dashboard.dashboard_id, warehouse_id=warehouse_id) diff --git a/tests/integration/test_dashboards.py b/tests/integration/test_dashboards.py index f2eae100..0d9c6ffc 100644 --- a/tests/integration/test_dashboards.py +++ b/tests/integration/test_dashboards.py @@ -58,7 +58,7 @@ def create(*, display_name: str = "") -> SDKDashboard: display_name = f"created_by_lsql_{make_random()}" else: display_name = f"{display_name} ({make_random()})" - dashboard = ws.lakeview.create(dashboard=SDKDashboard(display_name=display_name).as_dict()) + dashboard = ws.lakeview.create(dashboard=SDKDashboard(display_name=display_name)) if is_in_debug(): dashboard_url = f"{ws.config.host}/sql/dashboardsv3/{dashboard.dashboard_id}" webbrowser.open(dashboard_url)