Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging colors for dark terminal backgrounds #468

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Oct 17, 2023

image

@nfx nfx requested a review from a team October 17, 2023 22:21
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #468 (fc3ddab) into main (50301a6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   80.03%   80.05%   +0.01%     
==========================================
  Files          31       31              
  Lines        3176     3178       +2     
  Branches      610      610              
==========================================
+ Hits         2542     2544       +2     
  Misses        486      486              
  Partials      148      148              
Files Coverage Δ
src/databricks/labs/ucx/framework/logger.py 87.75% <100.00%> (+0.52%) ⬆️

@nfx nfx enabled auto-merge October 17, 2023 22:24
@nfx nfx disabled auto-merge October 18, 2023 17:10
@nfx nfx merged commit bd8214c into main Oct 18, 2023
@nfx nfx deleted the fix/log-colors branch October 18, 2023 17:10
@nfx nfx mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant