Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destroy-state-on-open #211

Merged
merged 3 commits into from
Mar 14, 2024
Merged

destroy-state-on-open #211

merged 3 commits into from
Mar 14, 2024

Conversation

tabmatfournier
Copy link
Contributor

  • be absolutely sure that objects are closed in open

@tabmatfournier
destroy-state-on-open
6a4370f 
- be absolutely sure that objects are closed in open
@tabmatfournier
destroy-state-on-open
ac4945d 
- a few more state clearing checks + ensuring file closing is synchronized
fqtab
fqtab approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@fqtab fqtab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tabmatfournier
second guessing myself to remove the clearing in exception handling, …
153babd 
…open/close should handle it already by removing the object
@tabmatfournier tabmatfournier merged commit 8cf3a3a into main Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqtab fqtab fqtab approved these changes

@danielcweeks danielcweeks danielcweeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabmatfournier @danielcweeks @fqtab