Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging default configuration with configuration in custom file #65

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

artemy-osipov
Copy link
Contributor

When Database-Rider configured via custom file, then missing parameters will be resolved to default java values, not to default values specified in documentation.
e.g. with this dbunit.yml

properties:
  qualifiedTableNames: true
  caseSensitiveTableNames: true
  escapePattern: "`?`"

missing parameter cacheConnection will be resolved to false

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 77.48% when pulling 85189ac on artemy-osipov:dbunit-config into 94d4f84 on database-rider:master.

@rmpestano
Copy link
Member

Thank you very much @artemy-osipov, I'll review as soon as possible and release a new version.

Happy new year!

@rmpestano rmpestano added this to the 1.2.6 milestone Jan 1, 2018
@rmpestano rmpestano merged commit 4387543 into database-rider:master Jan 4, 2018
@rmpestano
Copy link
Member

Thank you again for your great work @artemy-osipov!

@rmpestano rmpestano added the bug label Jan 4, 2018
@artemy-osipov artemy-osipov deleted the dbunit-config branch February 3, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants