Test suite: Creation of untagged images #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- loadImages function can now push images without setting a tag - Updated test cases accordingly Disclaimer: Did not figure out(yet) how to test action locally (thus there might be bugs) Proposed refinement: in the ci.yml, create a loop for single/multi to not repeat the test instructions
|
Seems to be errors in the action.xml. See above. Also not sure why the ci.yml isn't running on the PR. Were you able to run the ci.yml worflow on your local fork? |
|
Are you able to run the integration tests workflow in your fork? |
|
Oh, the ci.yml workflow is only setup to run on main. Change that the run on all branches. Then you'll be able to run ci workflow in your changes in your fork |
|
No I was not able to test it - couldn't figure out how to approach it. Will look into the ci workflow, thanks for the pointer |
|
Rebase your branch off the upstream main branch. I just main some changes which would enable the workflow on your repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: Did not figure out(yet) how to test action locally (thus there might be bugs)
Proposed refinement: in the ci.yml, create a loop for single/multi to not repeat the test instructions (created a PR for it: #17)