Merging passed initialValues from the schema and from props

[skateman]

I know that the initialValues passed to the FormRender component have a higher priority. However, if this attribute is set on the component, it ignores any initialValue attributes defined on the field level in the schema, even those which aren't set on the component level.

I discussed this with @rvsia and he said this is a bug, the two levels should be merged with the component level as priority.

[rvsia]

@Hyperkid123 What do you think?

[Hyperkid123]

@skateman I was under the impression that initialValue from schema has a higher priority. I will need to think about this for a moment.

[skateman]

Having the higher priority from the component actually makes more sense, but they should overlap and merge.

[Hyperkid123]

And how do you think the merge should look like? Can you provide a simple example?

[skateman]

So this setup:

const schema = {
  component: 'text-field',
  name: 'name',
},
{
  component: 'text-field',
  name: 'address',
  initialValue: 'Foo street'
},
{
  component: 'text-field',
  name: 'country',
  initialValue: 'Czech Republic'
};

const values = {
  name: 'John Doe',
  address: 'Bar street',
}

<FormRender schema={schema} initialValues={values}>;

Should return with the initial values:

{
  name: 'John Doe',
  address: 'Bar street',
  country: 'Czech Republic',
}

[Hyperkid123]

@skateman and that is not happening right now? That is how it should work.

[skateman]

Nope, it doesn't

[Hyperkid123]

Huh, that is strange. Ok, I will take a look at what is going on there. This is expected behavior and I was under the impression that it is working. Apparently not.

[Hyperkid123]

@skateman co I just tried the example you posted and I am getting the exact result you wanted. Can you provide more info please?

[Hyperkid123]

[skateman]

Maybe the problem is with dotted field names? It's happening on my openstack form in MiQ.

[Hyperkid123]

Lets try that

[Hyperkid123]

@skateman

const schema = {fields: [{
    component: 'text-field',
    name: 'name',
  },
  {
    component: 'text-field',
    name: 'bar.address',
    initialValue: 'Foo street'
  },
  {
    component: 'text-field',
    name: 'country',
    initialValue: 'Czech Republic'
  }]};
  
const values = {
name: 'John Doe',
bar: {
    address: 'Bar street',  
    }
}

same result as before

[Hyperkid123]

Maybe try update to latest version? There might have been a bug in previous.

or did you try to construct the nested value like this:

{
  'bar.address': 'value'
}

[skateman]

Still doesn't work with the latest, I have clearOnUnmount and clearedValue={null}on the form if that helps

[skateman]

Also it doesn't work for non-dotted fields, it just ignores any initialValue coming from the schema if the initialValues on the component is set to `{}˙.

[Hyperkid123]

Hmm. Still can't reproduce. Do you think you could create an example on code sandbox? No need to use any mapper just have some basic inputs.

[skateman]

I'm afraid it's cause by the fact that the form is being rendered on-demand 😕 so it might be miq-specific...

[Hyperkid123]

@skateman is it happening in one specific field? Or is there some sort of pattern?

[skateman]

It's a pattern, every field with an initialValue gets ignored in the cloud provider form 😕

[Hyperkid123]

Well, that is a big one... Can we check it together on Monday?

[skateman]

Wednesday the soonest, but sure. It's a tough one ...

[Hyperkid123]

@skateman closing this seems like the issue was on the MIQ side. Feel free to re-open this issue if you disagree.