Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of defaultProps usages to use default parameters instead #1439

Closed
danbrown7 opened this issue Jan 23, 2024 · 5 comments · Fixed by #1440
Closed

Refactor of defaultProps usages to use default parameters instead #1439

danbrown7 opened this issue Jan 23, 2024 · 5 comments · Fixed by #1440

Comments

@danbrown7
Copy link

Scope: All around the library

Description
When using numerous different components across the library, this error is received

Warning: FormTemplate: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Schema
Any minimal schema which uses a MUI Text box or something will reproduce this

Is there a timeline for this refactoring/will it be occuring?

@Hyperkid123
Copy link
Member

Hi @danbrown7

Is there a timeline for this refactoring/will it be occurring?

Not really. We had some plans to release a new major version of the packages, but it turned out there was no need for substantial changes.

So I think we should focus on the refactoring you have mentioned ASAP.

@Hyperkid123
Copy link
Member

@danbrown7 can you share what packages and what versions you use?

@danbrown7
Copy link
Author

@danbrown7 can you share what packages and what versions you use?

I currently use
react-form-renderer
common
mui-component-mapper

All on version 3.22.1

@Hyperkid123
Copy link
Member

@danbrown7 a new version with a fix should be released shortly.

@rvsia rvsia added the released label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants