Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Popup doesn't go away #259

Closed
piccoloaiutante opened this issue Feb 21, 2017 · 5 comments
Closed

Popup doesn't go away #259

piccoloaiutante opened this issue Feb 21, 2017 · 5 comments

Comments

@piccoloaiutante
Copy link

I think i found a bug and these are the step that consistently gave me the same outcome:

  • insert open.whitehouse.gov link to download dataset: 6fa91405f280c30cedd461dfcd3b4fffffb27759e26f8135b7cbdfe08870ccb2.

  • start download

  • then cancel it pressing 'yes, remove dat'.
    screen shot 2017-02-21 at 16 54 41

  • while download is still there click again on bin to cancel download.

  • press again 'yes, remove dat' button.

  • an error popup appears and even if you click on 'ok' puppy will stay there.
    screen shot 2017-02-21 at 16 53 58

Let me know if you aren't able to reproduce :)

@yoshuawuyts
Copy link
Contributor

Hey there 👋, thanks for reporting! Quick question:

while download is still there click again on bin to cancel download

By this, do you mean that the element eventually is removed, but not immediately - and if you click it it creates an error?

@yoshuawuyts yoshuawuyts self-assigned this Feb 22, 2017
@piccoloaiutante
Copy link
Author

yes @yoshuawuyts , because of the time taken to remove the user can click again and create this condition.

@yoshuawuyts
Copy link
Contributor

@piccoloaiutante great, I think I know how to solve it then. Thanks heaps for reporting!

@okdistribute okdistribute added this to the 2017-03-14 milestone Mar 15, 2017
@juliangruber
Copy link
Collaborator

@yoshuawuyts fixed the modal dismissal in b08cff0

@juliangruber
Copy link
Collaborator

fixed in master now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants