Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions on both send and recv in UCX comm #7130

Closed
wence- opened this issue Oct 10, 2022 · 3 comments · Fixed by #7132
Closed

Catch exceptions on both send and recv in UCX comm #7130

wence- opened this issue Oct 10, 2022 · 3 comments · Fixed by #7132

Comments

@wence-
Copy link
Contributor

wence- commented Oct 10, 2022

Following on from a review of #6996, there are a few other places in the UCX communicator backend where we should be catching exceptions on message transfer.

In addition, some of the try catch blocks can have their scope tightened (to avoid hiding other errors).

cc @pentschev, I will self-assign, but don't have privileges to do so.

@pentschev
Copy link
Member

Sorry @wence- , I dropped the ball on that discussion. I've opened #7132 to address what we discussed in #6996.

@wence-
Copy link
Contributor Author

wence- commented Oct 11, 2022

Sorry @wence- , I dropped the ball on that discussion. I've opened #7132 to address what we discussed in #6996.

Ah, when I said self-assign I meant that I would do it (but you got to it too fast!).

@pentschev
Copy link
Member

Ah, when I said self-assign I meant that I would do it (but you got to it too fast!).

I understood, but I said I would do it when we first discussed, unfortunately it slipped my mind after all the trouble we had to actually get #6996 in. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants