Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New feature] full code pickle for arbitrary modules #2268

Closed
crusaderky opened this issue Sep 23, 2018 · 4 comments
Closed

[New feature] full code pickle for arbitrary modules #2268

crusaderky opened this issue Sep 23, 2018 · 4 comments

Comments

@crusaderky
Copy link
Collaborator

As described in cloudpipe/cloudpickle#206
@jcrist
Copy link
Member

jcrist commented May 4, 2022

This has been added in cloudpipe/cloudpickle#417, and works fine with distributed & dask. I don't think there's anything we need to do on the dask side? Closing, feel free to reopen if more work is needed.

@jcrist jcrist closed this as completed May 4, 2022
@crusaderky
Copy link
Collaborator Author

cloudpickle now supports the feature, but distributed.protocol.pickle offers no way to disable pickle.
Functions imported from a module that exists locally but don't exist remotely will be successfully serialized with pickle on the client, but fail to deserialize on the workers.

As described in cloudpipe/cloudpickle#206, dask needs to offer a switch to completely bypass pickle or cloudpipe/cloudpickle#417 won't have a chance to run.

@crusaderky crusaderky reopened this Sep 21, 2022
@ian-r-rose
Copy link
Collaborator

This already works today cf #6466

@crusaderky
Copy link
Collaborator Author

Thanks for the clarification @ian-r-rose , I was not aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcrist @ian-r-rose @crusaderky