Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Use filter_push_down rule from DataFusion #908

Open
andygrove opened this issue Nov 8, 2022 · 0 comments
Open

[ENH] Use filter_push_down rule from DataFusion #908

andygrove opened this issue Nov 8, 2022 · 0 comments
Labels
enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When upgrading to DataFusion 14.0.0, we saw regressions in the test suite due to changes in filter_push_down that caused the filter to be rewritten in disjunctive normal form. The workaround was to add a copy of the rule from DataFusion 13.0.0 into the Dask SQL repo.

Describe the solution you'd like
Remove our copy and use DataFusion's. This may require changes in DataFusion.

Describe alternatives you've considered
None

Additional context
None
@andygrove andygrove added enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer labels Nov 8, 2022
@andygrove andygrove mentioned this issue Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs triage Awaiting triage by a dask-sql maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andygrove