-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: single node quorum #6437
base: develop
Are you sure you want to change the base?
feat: single node quorum #6437
Conversation
2fe82bc
to
52f567c
Compare
Guix Automation has began to build this PR tagged as v22.1.0-devpr6437.52f567c8. A new comment will be made when the image is pushed. |
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6437.52f567c8. The image should be on dockerhub soon. |
Please open a PR to update https://github.com/dashpay/dips/blob/master/dip-0006/llmq-types.md when this PR is merged |
This pull request has conflicts, please rebase. |
…ra blocks It also remove custom helper
Not sure if that's really useful, but can be changed
52f567c
to
0e2f96c
Compare
Guix Automation has began to build this PR tagged as v22.1.0-devpr6437.0e2f96ca. A new comment will be made when the image is pushed. |
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6437.0e2f96ca. The image should be on dockerhub soon. |
Guix Automation has began to build this PR tagged as v22.1.0-devpr6437.62360a30. A new comment will be made when the image is pushed. |
This pull request has conflicts, please rebase. |
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6437.62360a30. The image should be on dockerhub soon. |
Notes for reviewers
Issue being fixed or feature implemented
Development for platform requires currently to have running 4 Dash Core instances: wallet and at least 3 Evo Nodes which forms quorum.
This issue has been partially addressed #6261 to let use only 2 Evo Nodes. Though, it still requires all DKG steps, heavy network communication and various instability.
What was done?
This PR introduced new type of quorum "Single Node Quorum" with name
llmq_1_100
andid=111
for Regtest.This quorum needs just one node to be formed.
While regular quorum with several nodes 7 steps of creation (Initialization, Contribution, Complaining, Justification, Commitment, Finalization, Mining) this type of quorum just from Initialization straight to the Finalization.
The signing process with this quorum is also simplified. So far as regular quorum requires to sign multiple shares, for single node quorum the messages are signed immediately by just one node.
How Has This Been Tested?
See a new functional test
feature_llmq_singlenode.py
Also some other tests required changes, they are presented in prior commits
Breaking Changes
It introduces new quorum for Reg Test.
Checklist: