Fix ps collateral/denom creation tx category confusion (#2430)

* fix ps collateral/denom creation tx confusion * clarify the logic of detecting PrivateSendMakeCollaterals/PrivateSendCreateDenominations category
dashpay · Nov 10, 2018 · 5ecd91b · 5ecd91b
1 parent 0e9ad20
commit 5ecd91b
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/qt/transactionrecord.cpp b/src/qt/transactionrecord.cpp
@@ -155,13 +155,12 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const CWallet *
                     sub.type = TransactionRecord::PrivateSendCollateralPayment;
                 } else {
                     for (const auto& txout : wtx.tx->vout) {
-                        if(txout.nValue == CPrivateSend::GetMaxCollateralAmount()) {
+                        if (txout.nValue == CPrivateSend::GetMaxCollateralAmount()) {
                             sub.type = TransactionRecord::PrivateSendMakeCollaterals;
-                            break;
-                        }
-                        if(CPrivateSend::IsDenominatedAmount(txout.nValue)) {
+                            continue; // Keep looking, could be a part of PrivateSendCreateDenominations
+                        } else if (CPrivateSend::IsDenominatedAmount(txout.nValue)) {
                             sub.type = TransactionRecord::PrivateSendCreateDenominations;
-                            break;
+                            break; // Done, it's definitely a tx creating mixing denoms, no need to look any further
                         }
                     }
                 }