Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: fake asset lock must be passed only for regtest #90

Merged
merged 1 commit into from
Dec 28, 2020
Merged

fix: fake asset lock must be passed only for regtest #90

merged 1 commit into from
Dec 28, 2020

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Dec 25, 2020 •
edited
Loading

Issue being fixed or feature implemented

passFakeAssetLockProofForTests needs only on local network (regtest) since we don't have quorums

What was done?

Enable passFakeAssetLockProofForTests for regtest only

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested review from antouhou and jawid-h December 25, 2020 12:44
@shumkov shumkov added this to the v0.17 milestone Dec 25, 2020
@shumkov shumkov marked this pull request as ready for review December 25, 2020 13:01
shuplenkov
shuplenkov approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit cbd3625 into v0.17-dev Dec 28, 2020
@shumkov shumkov deleted the pass-fake branch December 28, 2020 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuplenkov shuplenkov shuplenkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

@jawid-h jawid-h Awaiting requested review from jawid-h

Assignees
No one assigned
Labels
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @shuplenkov