Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: remove pending subscribeToTransactionsWithProofs functional tests #72

Merged
merged 1 commit into from
Sep 4, 2020
Merged

feat: remove pending subscribeToTransactionsWithProofs functional tests #72

merged 1 commit into from
Sep 4, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Sep 4, 2020

Issue being fixed or feature implemented

We're removing pending functional tests as we keep them in dapi

What was done?

Removed pending tests

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.15 milestone Sep 4, 2020
@jawid-h jawid-h requested a review from shumkov September 4, 2020 13:46
shumkov
shumkov approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 3045b0e into v0.15-dev Sep 4, 2020
@shumkov shumkov deleted the feat/remove-pending-tx-tests branch September 4, 2020 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov