Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

refactor: use Wallet lib instead of getUTXO #62

Merged
merged 8 commits into from
Sep 2, 2020

Conversation

Alex-Werner
Copy link
Contributor

Issue being fixed or feature implemented

In order to remove getUTXO, and have a fully functional coverage, we switch from getUTXO to wallet into our test-suite.

What was done?

  • modified funding logic from individual components to SDK
  • removed getUTXO
  • removed fundAddress (for fundAccount)

How Has This Been Tested?

This is actually some tests modifications.

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner added this to the v0.15 milestone Aug 26, 2020
lib/test/createClientWithFundedWallet.js Outdated Show resolved Hide resolved
@shumkov shumkov changed the title feat: getUTXO, transactions, broadcast and funding using dash sdk instead of getUTXO refactor: use Wallet lib instead of getUTXO Sep 2, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit 7e0c71a into v0.15-dev Sep 2, 2020
@shumkov shumkov deleted the feat/usage-with-dash-sdk branch September 2, 2020 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants