Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: functional core tests #33

Merged
merged 6 commits into from
May 5, 2020
Merged

feat: functional core tests #33

merged 6 commits into from
May 5, 2020

Conversation

shuplenkov
Copy link
Member

No description provided.

shuplenkov added 5 commits April 28, 2020 13:11
@shuplenkov shuplenkov requested review from shumkov, antouhou and jawid-h May 4, 2020 16:25
Copy link
Contributor

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not forget to update contacts tests with latest changes from use-dashjs branch to avoid conflicts in the future.

.env.example Outdated
@@ -2,3 +2,4 @@
DAPI_SEED=
FAUCET_PRIVATE_KEY=
NETWORK=
DASHJS_SEED=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, we could reuse DAPI_SEED for setting up DashJS client.

.fee(668)
.sign(faucetPrivateKey);

return dapiClient.sendTransaction(transaction.toBuffer());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for a few blocks here?

@jawid-h jawid-h self-requested a review May 5, 2020 10:45
Copy link
Contributor

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@shuplenkov shuplenkov merged commit 100d50d into master May 5, 2020
@shuplenkov shuplenkov deleted the functional-core branch May 5, 2020 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants