Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: add proof test for all endpoints and appHash extraction #163

Merged
merged 9 commits into from
Sep 16, 2021

Conversation

antouhou
Copy link
Contributor

@antouhou antouhou commented Sep 13, 2021

Please merge this one after dashevo/js-drive#563 gets merged, so future PRs to drive won't be blocked

Issue being fixed or feature implemented

Add tests for proofs

What was done?

Add e2e test for appHash extraction from all endpoint that provide proofs

How Has This Been Tested?

Run the tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe a rationale behind of this test having more descriptive test name and comments

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit 5e18783 into v0.21-dev Sep 16, 2021
@shumkov shumkov deleted the feat-proof-tests branch September 16, 2021 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants