Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: use new Drive's error codes #162

Merged
merged 8 commits into from
Sep 15, 2021
Merged

feat: use new Drive's error codes #162

merged 8 commits into from
Sep 15, 2021

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Sep 13, 2021

Issue being fixed or feature implemented

Since we are using new error codes, we need to update dependencies and tests

What was done?

Updated dependencies and tests

How Has This Been Tested?

With tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.21.0 milestone Sep 13, 2021
@shuplenkov shuplenkov requested a review from shumkov September 13, 2021 16:39
@shumkov shumkov changed the title feat: update tests for new error codes feat: use new Drive's error codes Sep 15, 2021
@@ -22,14 +22,14 @@
"@dashevo/dashcore-lib": "~0.19.25",
"@dashevo/dpns-contract": "github:dashevo/dpns-contract#update-dpp",
"@dashevo/feature-flags-contract": "github:dashevo/feature-flags-contract#update-dpp",
"@dashevo/dpp": "~0.21.0-dev.2",
"@dashevo/dpp": "~0.21.0-dev.4",
"@dashevo/grpc-common": "~0.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~0.4.1

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s ok for now 😁

@shumkov shumkov merged commit f08ee65 into v0.21-dev Sep 15, 2021
@shumkov shumkov deleted the error-codes branch September 15, 2021 12:20
@shumkov shumkov restored the error-codes branch September 15, 2021 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants