Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix planar BigTIFF ingestion (DEV-3384) #455

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Sep 23, 2024

Since the files that are to be tested range in the multiple gigabytes (when uncompressed) and will take a lot of space and time when testing, they have not been added to the test suite. Accordingly, the fix will be tested on the dev env.

As before, when ingesting a tiled BigTiff, an error noting the incompatibility will be issued.

Copy link

linear bot commented Sep 23, 2024

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.5%. Comparing base (d5eaab3) to head (7c6b91c).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/formats/SipiIOTiff.cpp 29.1% <ø> (ø)

... and 1 file with indirect coverage changes

@siers siers force-pushed the feat/DEV-3384-big-tiff-support branch from d6f9767 to 7c6b91c Compare September 23, 2024 11:16
@siers siers requested a review from subotic September 23, 2024 11:29
Copy link
Contributor

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@siers siers merged commit 83c2c94 into main Sep 24, 2024
7 checks passed
@siers siers deleted the feat/DEV-3384-big-tiff-support branch September 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants