Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and clear accounts that have non-zerofrozen field #1483

Closed
hackfisher opened this issue Apr 21, 2024 · 13 comments · Fixed by #1485
Closed

Review and clear accounts that have non-zerofrozen field #1483

hackfisher opened this issue Apr 21, 2024 · 13 comments · Fixed by #1485
Assignees
Labels
B-Runtime [Bug] Some mistakes with the runtime logic

Comments

@hackfisher
Copy link
Contributor

  • Why those accounts have non-zerofrozen field ? Example
  • Clear if they are not needed anymore.
@hackfisher hackfisher added the P-Mid [Priority] Median label Apr 21, 2024
@hackfisher
Copy link
Contributor Author

0xC1c8F6Ef43b39C279417E361969d535F2a20b92e

@AurevoirXavier
Copy link
Member

It's also worth to check frozen field for #1460.

@hackfisher
Copy link
Contributor Author

  • Why those accounts have non-zerofrozen field ? Example
  • Clear if they are not needed anymore.

Some additional information, there is no locks and reserves in balance pallet for this account.

So I guess it probably be some data imported from Darwinia 1.0?

@2xJDubs
Copy link

2xJDubs commented Apr 24, 2024

All the voting for this account has been recently done in Darwinia2.0 OpenGov.

@AurevoirXavier
Copy link
Member

AurevoirXavier commented Apr 24, 2024

Some additional information, there is no locks and reserves in balance pallet for this account.

So I guess it probably be some data imported from Darwinia 1.0?

("0x7ae2a0914db8bfbdad538b0eac3fa473a0e07843", b"phrelect"),

Removed the locks but didn't clear the account data here.

That's why I said.

It's also worth to check frozen field for #1460

I'll give a solution today.

@2xJDubs
Copy link

2xJDubs commented Apr 24, 2024

From what I can now tell that caused this issue is that when making staking deposits I was somehow able to include RING that was associated with either locked or reserved RING which caused the the account to drop below 0 transferable RING, in fact it dropped around 10000 RING below what was locked and reserved. By transferring in 10000 RING to the address and bringing the balance above the locked and reserved the account became usable again.

The big question here is how was I able to include RING that was locked/reserved in a staking deposit?

@AurevoirXavier
Copy link
Member

The big question here is how was I able to include RING that was locked/reserved in a staking deposit

Please wait for the runtime upgrade. There's also some gov1 frozen funds.

@AurevoirXavier
Copy link
Member

AurevoirXavier commented Apr 25, 2024

0x71571c42067900bfb7ca8b51fccc07ef77074aea 4000000000000000000 []
0xabcf7060a68f62624f7569ada9d78b5a5db0782a 20000000000000000000000 [ { id: 'pyconvot', amount: '20000000000000000000000' } ]
0x822e4e429adedd91c96a81db39401a1770b96a5b 1000000000000000000 [ { id: 'pyconvot', amount: '1000000000000000000' } ]
0x5391d52546b4e8afeb09591605a386bd36219054 141102000000000000000000 [ { id: 'pyconvot', amount: '141102000000000000000000' } ]
0x88a39b052d477cfde47600a7c9950a441ce61cb4 3000000000000000000000 [ { id: 'pyconvot', amount: '3000000000000000000000' } ]
0x9f33a4809aa708d7a399fedba514e0a0d15efa85 10000000000000000000000 [ { id: 'pyconvot', amount: '10000000000000000000000' } ]
0x1116bffe122485addff8d182caa91c94b05e490c 10000000000000000000000 [ { id: 'pyconvot', amount: '10000000000000000000000' } ]
0x0a1287977578f888bdc1c7627781af1cc000e6ab 5000000000000000000000 []
0x0b001c95e86d64c1ad6e43944c568a6c31b53887 660000000000000000000 []
0xb96b4429d522a210ecc3d1b2d3b0f4026588c340 10000000000000000000000 [ { id: 'pyconvot', amount: '10000000000000000000000' } ]
0x6ddf9e3168ff67f1c0416879390d7e6557b87b66 6700000000000000000000000 [ { id: 'pyconvot', amount: '6700000000000000000000000' } ]
0xe59261f6d4088bcd69985a3d369ff14cc54ef1e5 1500000000000000000000 [ { id: 'pyconvot', amount: '1500000000000000000000' } ]
0x1a469e3e616cbe7a7c40ec6b3e097aadc2905a0a 936000000000000000000 [ { id: 'pyconvot', amount: '936000000000000000000' } ]
0x081cbab52e2dbcd52f441c7ae9ad2a3be42e2284 124672583586849335000000000 [ { id: 'vesting ', amount: '124672583586849335000000000' } ]
0xb5727469dfcfdbdcd9592eb1bb3bdcbc50a9da05 10000000000000000000 [ { id: 'pyconvot', amount: '10000000000000000000' } ]
0xb4a488b072b9d75909d7a7c42da8e03e43e40ac3 300000000000000000000 [ { id: 'pyconvot', amount: '300000000000000000000' } ]
0xfa5727be643dba6599fc7f812fe60da3264a8205 1000000000000000000000 []
0xefb73e47099485c72b7678cb59fb0da7dacf173f 9203000000000000000000 [ { id: 'pyconvot', amount: '9203000000000000000000' } ]
0x5ebdfe236a8a75cc379ac2ad8cd754ee38297477 180000000000000000000000 [ { id: 'pyconvot', amount: '180000000000000000000000' } ]
0x1c647cb0e7cab8328aa57c5a34e34e40686c1e00 10000000000000000000 [ { id: 'pyconvot', amount: '10000000000000000000' } ]
0xf4b88608ba19df20815015df57acc9328f1ee2f3 100000000000000000000000 [ { id: 'pyconvot', amount: '100000000000000000000000' } ]
0x33bd8d5a4f40285df90694ccb29d6f5859c3977e 8000000000000000000000 [ { id: 'pyconvot', amount: '8000000000000000000000' } ]
0x3e25247cff03f99a7d83b28f207112234fee73a6 1200000000000000000000000 [ { id: 'pyconvot', amount: '1200000000000000000000000' } ]
0xb2960e11b253c107f973cd778bbe1520e35e8602 100000000000000000000000 [ { id: 'pyconvot', amount: '100000000000000000000000' } ]
0xe45fd7bef2736dad2d5620052ca37a9603376aea 10000000000000000000000 [ { id: 'pyconvot', amount: '10000000000000000000000' } ]
0x5af9a1be7bc22f9a6b2ce90acd69c23dceeb23c2 660000000000000000000 []
0x1678a973ae9750d25c126cdbce891bb8cfacd520 660000000000000000000 []
0xc1c8f6ef43b39c279417e361969d535f2a20b92e 260000000000000000000000 [ { id: 'pyconvot', amount: '260000000000000000000000' } ]
0xbd5a5d450f452d5adb85dacd6d52aa10fef77148 9000000000000000000000 [ { id: 'pyconvot', amount: '9000000000000000000000' } ]
0x5dd68958e07cec3f65489db8983ad737c37e0646 4000000000000000000000 []
0xf11d8d9412fc6b90242e17af259cf7bd1eaa416b 10000000000000000000 []
0x849887b4ebd54eda52485844dff9bc4574bdfdcd 1100000000000000000 [ { id: 'pyconvot', amount: '1100000000000000000' } ]
0x3c6d95527f6843c91602e91e97e6133311436508 1000000000000000000 [ { id: 'pyconvot', amount: '1000000000000000000' } ]
0x52f6cbe5f29094d235df65e31b67977a235e6380 20000000000000000000000000 [
  { id: 'pyconvot', amount: '20000000000000000000000000' },
  { id: 'democrac', amount: '20000000000000000000000000' }
]
0x25fffa710cbe44d816d901de27b199ff690d5614 1660000000000000000000 [ { id: 'pyconvot', amount: '1660000000000000000000' } ]
0xdca962b899641d60ccf7268a2260f20b6c01c06d 1000000000000000000 []

@AurevoirXavier
Copy link
Member

AurevoirXavier commented Apr 25, 2024

These accounts need to be fixed on Darwinia:

0x71571c42067900bfb7ca8b51fccc07ef77074aea
0x0a1287977578f888bdc1c7627781af1cc000e6ab
0x0b001c95e86d64c1ad6e43944c568a6c31b53887
0xfa5727be643dba6599fc7f812fe60da3264a8205
0x5af9a1be7bc22f9a6b2ce90acd69c23dceeb23c2
0x1678a973ae9750d25c126cdbce891bb8cfacd520
0x5dd68958e07cec3f65489db8983ad737c37e0646
0xf11d8d9412fc6b90242e17af259cf7bd1eaa416b
0xdca962b899641d60ccf7268a2260f20b6c01c06d

@AurevoirXavier
Copy link
Member

0xd891ce6a97b4f01a8b9b36d0298aa3631fe2eef5 10000000000000000000000 []
0xabcf7060a68f62624f7569ada9d78b5a5db0782a 2000000000000000000000 [ { id: 'pyconvot', amount: '2000000000000000000000' } ]
0x88a39b052d477cfde47600a7c9950a441ce61cb4 1000000000000000000 []
0x9f33a4809aa708d7a399fedba514e0a0d15efa85 700473045624002882797 [ { id: 'pyconvot', amount: '700473045624002882797' } ]
0x0a1287977578f888bdc1c7627781af1cc000e6ab 13767198376240536966688 []
0x0b001c95e86d64c1ad6e43944c568a6c31b53887 160000000000000000000 []
0x3d6a81177e17d5dbbd36f23ea5328acdf3471209 99993679980000000000 [ { id: 'vesting ', amount: '99993679980000000000' } ]
0xe59261f6d4088bcd69985a3d369ff14cc54ef1e5 500475994586640576300 [ { id: 'pyconvot', amount: '500475994586640576300' } ]
0x7ae2a0914db8bfbdad538b0eac3fa473a0e07843 280000000000000000000000 []
0xacfa39b864e42d1bd3792783a571d2958af0bf1f 1500000000000000000000000 [ { id: 'phrelect', amount: '20000000000000000000000' } ]
0x3e25247cff03f99a7d83b28f207112234fee73a6 5000000000000000000000000 [ { id: 'pyconvot', amount: '5000000000000000000000000' } ]
0xb2960e11b253c107f973cd778bbe1520e35e8602 8000000000000000000000000 [ { id: 'pyconvot', amount: '8000000000000000000000000' } ]
0x5af9a1be7bc22f9a6b2ce90acd69c23dceeb23c2 372000000000000000000 []
0x1678a973ae9750d25c126cdbce891bb8cfacd520 372000000000000000000 []
0x4ed7ae57608cf4f60753cde4f49cf821c293ed2a 80000000000000000000 []
0x5b7544b3f6abd9e03fba494796b1ee6f9543e2e4 500000000000000000000 []
0x44cda595218ddb3810fb66c2e982f50ea00255ee 99793500000000000000 []

@AurevoirXavier
Copy link
Member

AurevoirXavier commented Apr 25, 2024

These accounts need to be fixed on Crab:

0xd891ce6a97b4f01a8b9b36d0298aa3631fe2eef5
0x88a39b052d477cfde47600a7c9950a441ce61cb4
0x0a1287977578f888bdc1c7627781af1cc000e6ab
0x0b001c95e86d64c1ad6e43944c568a6c31b53887
0x7ae2a0914db8bfbdad538b0eac3fa473a0e07843
0xacfa39b864e42d1bd3792783a571d2958af0bf1f
0x5af9a1be7bc22f9a6b2ce90acd69c23dceeb23c2
0x1678a973ae9750d25c126cdbce891bb8cfacd520
0x4ed7ae57608cf4f60753cde4f49cf821c293ed2a
0x5b7544b3f6abd9e03fba494796b1ee6f9543e2e4
0x44cda595218ddb3810fb66c2e982f50ea00255ee

@AurevoirXavier AurevoirXavier added B-Runtime [Bug] Some mistakes with the runtime logic and removed P-High [Priority] High labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-Runtime [Bug] Some mistakes with the runtime logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants