You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As it currently stands, a .skel file can return either a Skeleton or a World object. This is somewhat unintuitive, and can probably lead to confusion about which parsing function to call for any given file.
I propose instead returning a struct. Something like this:
This way everything that a file can possibly contain is obtainable through a single parsing function. It would also address an issue brought up in #378: this would allow ReferentialSkeletons that encapsulate multiple Skeletons to be defined.
The text was updated successfully, but these errors were encountered:
I also wonder if we should consider using a file extension besides .skel, since it sort of implies that the file will only contain a single Skeleton, which is not accurate.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
As it currently stands, a .skel file can return either a Skeleton or a World object. This is somewhat unintuitive, and can probably lead to confusion about which parsing function to call for any given file.
I propose instead returning a struct. Something like this:
This way everything that a file can possibly contain is obtainable through a single parsing function. It would also address an issue brought up in #378: this would allow ReferentialSkeletons that encapsulate multiple Skeletons to be defined.
The text was updated successfully, but these errors were encountered: