Better logging in random_test.dart, and less overall noise from warnings #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
szakarias
approved these changes
May 30, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 30, 2024
…on, dartdoc, logging, markdown, shelf, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/cf90551..b3608bd): b3608bd 2024-05-28 Kevin Moore bump lints dep and fix (dart-archive/args#275) async (https://github.com/dart-lang/async/compare/77a25d7..f933ddf): f933ddf 2024-05-28 Kevin Moore bump lints dep and fix (dart-archive/async#275) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/accc755..6fa42b0): 6fa42b0 2024-05-28 Kevin Moore bump lints dep and fix (dart-archive/benchmark_harness#106) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/2cbd4a6..84467e5): 84467e5 2024-05-28 Kevin Moore bump lints dep and fix (dart-archive/boolean_selector#61) collection (https://github.com/dart-lang/collection/compare/4718398..fe2e800): fe2e800 2024-05-28 Kevin Moore bump lints dep and fix (dart-archive/collection#344) dartdoc (https://github.com/dart-lang/dartdoc/compare/1e1a004..ed97585): ed975850 2024-05-28 Sam Rawlins Fix flutter CI with re-internalized snippets tool (dart-lang/dartdoc#3776) logging (https://github.com/dart-lang/logging/compare/49d89b1..7f722dc): 7f722dc 2024-05-30 Jonas Finnemann Jensen Add `topics` to `pubspec.yaml` (dart-archive/logging#164) markdown (https://github.com/dart-lang/markdown/compare/340c76f..c1013dc): c1013dc 2024-05-28 Kevin Moore update lints dependency (dart-lang/markdown#613) 7a3b8d6 2024-05-28 Sam Rawlins Bump to 7.2.3 (dart-lang/markdown#612) shelf (https://github.com/dart-lang/shelf/compare/d9f82bf..338962c): 338962c 2024-05-28 Kevin Moore update lints dependency (dart-lang/shelf#433) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/3191934..963e7a3): 963e7a3 2024-05-30 Jonas Finnemann Jensen Update CHANGELOG.md (dart-lang/yaml_edit#82) 8fdc96d 2024-05-30 Jonas Finnemann Jensen Better logging in random_test.dart, and less overall noise from warnings (dart-lang/yaml_edit#81) Change-Id: I8648cd3c740fbe8ad6a658ae5ed2b5be5c01e2ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368822 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we never set
yamlWarningCallbackwhen parsing YAML internally, this meant that the terminal would show warnings.This is sad, because some of the internal stuff really only used
loadYamlNodeto determine if a string needed to be quoted, or if the edits were sane -- so warnings aren't actually intended for the end-user.One could argue that we should avoid edits that produce warnings, but that seems to an orthogonal concern, this really just stops warnings produces internally from polluting stdout.