Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links to package issue trackers #1190

Merged
merged 2 commits into from
Nov 7, 2024
Merged

add links to package issue trackers #1190

merged 2 commits into from
Nov 7, 2024

Conversation

devoncarew
Copy link
Member

  • add links to package issue trackers in the main readme
  • add links to package issue trackers from the pubspec files (using the issue_tracker field)
  • various minor normalization of repo files

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@coveralls
Copy link

coveralls commented Nov 7, 2024

Pull Request Test Coverage Report for Build 11728688849

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.985%

Totals Coverage Status
Change from base Build 11670808043: 0.0%
Covered Lines: 623
Relevant Lines: 670

💛 - Coveralls

Copy link

github-actions bot commented Nov 7, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
bazel_worker None 1.1.3-wip 1.1.3-wip 1.1.3-wip ✔️
benchmark_harness None 2.3.1 2.3.1 2.3.1 ✔️
boolean_selector None 2.1.2 2.1.2 2.1.2 ✔️
browser_launcher None 1.1.3 1.1.3 1.1.3 ✔️
cli_config None 0.2.1-wip 0.2.1-wip 0.2.1-wip ✔️
cli_util None 0.4.2 0.4.2 0.4.2 ✔️
clock None 1.1.2 1.1.2 1.1.2 ✔️
code_builder None 4.10.1 4.10.1 4.10.1 ✔️
coverage None 1.10.0 1.10.0 1.10.0 ✔️
csslib None 1.0.2 1.0.2 1.0.2 ✔️
extension_discovery None 2.1.0 2.1.0 2.1.0 ✔️
file None 7.0.1 7.0.1 7.0.1 ✔️
file_testing None 3.0.2 3.0.2 3.0.2 ✔️
graphs None 2.3.3-wip 2.3.3-wip 2.3.3-wip ✔️
html None 0.15.5 0.15.5 0.15.5 ✔️
json_rpc_2 None 3.0.3 3.0.3 3.0.3 ✔️
mime None 2.0.0 2.0.0 2.0.0 ✔️
oauth2 None 2.0.4-wip 2.0.4-wip 2.0.4-wip ✔️
source_map_stack_trace None 2.1.3-wip 2.1.3-wip 2.1.3-wip ✔️
unified_analytics None 6.1.4 6.1.4 6.1.4 ✔️
Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
benchmark_harness Measurement
boolean_selector All
None
code_builder SpecVisitor
ClosureExpression
LiteralSetExpression
LiteralMapExpression
LiteralRecordExpression
csslib Messages
html HtmlTokenizer
Token
HtmlInputStream
TagToken
DoctypeToken
StringToken
TreeBuilder
ActiveFormattingElements
StartTagToken
TagAttribute
CommentToken
CharactersToken
SpaceCharactersToken
EndTagToken
unified_analytics Condition
PersistedSurvey
GAClient
UserProperty

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/bazel_worker/lib/src/worker_protocol.pb.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart

@devoncarew
Copy link
Member Author

The package:graphs workflow is failing due to dart-lang/sdk#57045.

@devoncarew devoncarew requested a review from natebosch November 7, 2024 19:38
@devoncarew devoncarew merged commit 0482672 into main Nov 7, 2024
79 of 82 checks passed
@devoncarew devoncarew deleted the issue_links branch November 7, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment