Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeout #666

Merged
merged 3 commits into from
Aug 4, 2017
Merged

Extend timeout #666

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c533750
extend timeout
grouma Jul 18, 2017
f35b674
bump number
grouma Jul 18, 2017
ad7d635
merge
grouma Aug 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.12.24-dev

* Extend `deserializeTimeout`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DBC: This could be worded better. Changelog entries should generally be written to be consumed by end-users, who won't have any idea what deserializeTimeout refers to, especially when it's formatted like a Dart identifier. Something like "Time out more slowly when loading test suites" would be clearer and more user-focused.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Thanks.


## 0.12.24

* Add a `node` platform for compiling tests to JavaScript and running them on
Expand Down
2 changes: 1 addition & 1 deletion lib/src/runner/plugin/platform_helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import '../runner_test.dart';

typedef StackTrace _MapTrace(StackTrace trace);

final _deserializeTimeout = new Duration(minutes: 3);
final _deserializeTimeout = new Duration(minutes: 8);

/// A helper method for creating a [RunnerSuiteController] containing tests
/// that communicate over [channel].
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test
version: 0.12.24
version: 0.12.24-dev
author: Dart Team <[email protected]>
description: A library for writing dart unit tests.
homepage: https://github.com/dart-lang/test
Expand Down