Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md, remove link to Stream Matchers #2187

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Update README.md, remove link to Stream Matchers #2187

merged 2 commits into from
Feb 26, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Feb 23, 2024 •
edited by jakemac53
Loading

This section was removed: cc0598b#diff-c97f9e0d4b6adec304ed041e0063f78a4842c22d03bcaa5086a66c9d49aeab98

I have no idea what else should be removed or added from the ToC, and I have no idea how you would maintain this ToC.

Fixes #2188

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Update README.md, remove link to Stream Matchers
ab9af36 
This section was removed: cc0598b#diff-c97f9e0d4b6adec304ed041e0063f78a4842c22d03bcaa5086a66c9d49aeab98

I have no idea what else should be removed or added from the ToC, and I have no idea how you would maintain this ToC.
jakemac53
jakemac53 reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we do also need to bump the version and add a changelog entry (to a -wip patch version)

@srawlins
Copy link
Member Author

OK, I'll just close and open an issue instead.

@srawlins srawlins closed this Feb 23, 2024
@srawlins srawlins mentioned this pull request Feb 23, 2024
Closed
@jakemac53 jakemac53 reopened this Feb 23, 2024
@jakemac53
Copy link
Contributor

Re-opened and uploaded the changelog/pubspec edits

@jakemac53 jakemac53 requested a review from natebosch February 23, 2024 18:40
@jakemac53
Copy link
Contributor

Added Nate to approve those just so I am not approving my own stuff 🤣

@srawlins
Copy link
Member Author

Thanks!

@natebosch natebosch merged commit 26953ba into master Feb 26, 2024
35 checks passed
@natebosch natebosch deleted the srawlins-patch-1 branch February 26, 2024 20:03
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 28, 2024
@devoncarew
[deps] rev dartdoc, markdown, mockito, test, tools, web
e0e6231 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/40c470e..eed92d3):
  eed92d3f  2024-02-28  Sam Rawlins  Simplify InheritingContainer.allModelElements and _inheritedElements (dart-lang/dartdoc#3689)
  7b3274a6  2024-02-28  Sam Rawlins  Do not require FLUTTER_ROOT any longer, even for flutter packages (dart-lang/dartdoc#3688)
  d25dfca4  2024-02-27  Kallen Tu  Remove LanguageFeatureRenderer. (dart-lang/dartdoc#3686)
  d8e7f99c  2024-02-27  Sam Rawlins  Display the immediate representation type, not any erasure (dart-lang/dartdoc#3685)
  91c361af  2024-02-27  Kallen Tu  Remove SourceCodeRenderer and TypeParametersRenderer. (dart-lang/dartdoc#3683)

markdown (https://github.com/dart-lang/markdown/compare/d735b0b..62e3349):
  62e3349  2024-02-27  Tom Yeh  Fix `#586`: encode image tag's src attribute (dart-lang/markdown#589)

mockito (https://github.com/dart-lang/mockito/compare/7d6632f..3ef744f):
  3ef744f  2024-02-27  Ilya Yanok  Bump SDK version using in CI to 3.3
  ecec7c1  2024-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.6.0 to 1.6.2
  b693ada  2024-02-27  Ilya Yanok  Add basic extension types support

test (https://github.com/dart-lang/test/compare/a3f05ec..26953ba):
  26953ba4  2024-02-26  Sam Rawlins  Update README.md, remove link to Stream Matchers (dart-lang/test#2187)

tools (https://github.com/dart-lang/tools/compare/c7fbf26..fca993e):
  fca993e  2024-02-28  Elias Yishak  Fix late initialization error for `Analytics.userProperty` (dart-lang/tools#239)
  1a0d7da  2024-02-26  Elias Yishak  Export `testing.dart` with all enums (dart-lang/tools#237)

web (https://github.com/dart-lang/web/compare/d96c01d..fa4280c):
  fa4280c  2024-02-27  Devon Carew  mention the migration guide in the readme (dart-lang/web#187)

Change-Id: Ib183b4af55146fdeabfb18dc91bf642159e67a1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354963
Reviewed-by: Kevin Moore <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 left review comments

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/README.md has broken link in ToC to "Stream matchers"
3 participants
@srawlins @jakemac53 @natebosch