Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dart: prefix for unittest library #135

Closed
DartBot opened this issue Jun 5, 2015 · 8 comments
Closed

Add dart: prefix for unittest library #135

DartBot opened this issue Jun 5, 2015 · 8 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="96" height="96"hspace="10"> Issue by sethladd
Originally opened as dart-lang/sdk#3431


The unittest library should be accessible via dart: prefix. This will be a heavily used library by external developers who are sharing code, and thus the current solution of absolute paths isn't sufficient.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5449880?v=3" align="left" width="48" height="48"hspace="10"> Comment by iposva-google


I suggest that this library is being added using pub instead of dart:, overall we should carefully weigh which libraries are elevated to dart: level and which are packages that we supply.


cc @kasperl.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


What's the bar for getting into the dart: club? I'd love to see one syntax so we don't have to weigh the pros and cons of how we import different individual libraries.

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) closed-not-planned Closed as we don't intend to take action on the reported issue Priority-Medium labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


For the record, see https://groups.google.com/a/dartlang.org/forum/#!topic/misc/X8qDr24yzXM for public discussion.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Related to bug 3702

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This comment was originally written by [email protected]


Unit testing is really important. Since the language is changing, building anything non-trivial on top of Dart like a reusable framework requires continuous confidence that the framework is in-sync with the language, and unit tests help us figure that out. Pub is still green, and is itself changing. Forcing third-party framework vendors to use a sketchy tool to get to the the unit test library does nothing more than encourage us to move on to another language.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


The unittest library will be available via pub. The unittest library is shipping in the SDK today, under the pkgs directory. With pub, you should be able to include it with:

dependencies:
  unittest:
    sdk: unittest


Added WontFix label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Added Pkg-Unittest label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Removed Area-UnitTest label.
Added Area-Pkg label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant