Fix factory constructor example #5889
Conversation
|
Visit the preview URL for this PR (updated for commit 8120829): |
| ```dart | ||
| // Implement this factory constructor. | ||
| factory IntegerHolder.fromList(List<int> list) { | ||
| if (list.length == 1) { |
There was a problem hiding this comment.
Could this be a switch statement?
|
|
||
| if (obj is! IntegerSingle) { | ||
| errs.add('Called IntegerHolder.fromList([1]) and got an object of type \n ${obj.runtimeType} instead of IntegerSingle.'); | ||
| switch (count) { |
There was a problem hiding this comment.
I think we might be able to use pattern matching here
| } catch (e) { | ||
| print('Called IntegerSingle.fromList([]) and got an exception of \n type ${e.runtimeType}.'); | ||
| return; | ||
| if (!testBadNumberOfArgs(errs, 0)) return; |
There was a problem hiding this comment.
It's not quite clear to me what this code is doing. Can I have a brief description?
| } catch (e) { | ||
| print('Called IntegerHolder.fromList([1, 2]) and got an exception \n of type ${e.runtimeType}.'); | ||
| return; | ||
| testValueOfA( |
There was a problem hiding this comment.
What does A, ABC, and X represent?
|
|
||
| bool testBadNumberOfArgs(List<String> errs, int count) { | ||
| assert(count == 0 || count == 4); |
There was a problem hiding this comment.
should this check be in a separate function that is to test the value as opposed to the test itself?
|
|
||
| bool testGoodNumberOfArgs(List<String> errs, int count) { | ||
| assert(1 <= count && count <= 3); |
There was a problem hiding this comment.
same here with this assert
|
|
||
| // Tests your solution (Don't edit!): | ||
| // Tests your solution (Don't edit from this point to end of file): |
There was a problem hiding this comment.
My primary concern here is that these tests are now more difficult to follow than they were previously in the context of a cheatsheet. Can it be simplified a bit more? @johnpryan @parlough can you double check me on that?
atsansone
added
st.RFM
Fixes #5615
Fixes #5616