Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub: symlinks within the project confused it #9418

Closed
jmesserly opened this issue Mar 25, 2013 · 6 comments
Closed

pub: symlinks within the project confused it #9418

jmesserly opened this issue Mar 25, 2013 · 6 comments
Assignees
Labels
P3 A lower priority bug or feature request

Comments

@jmesserly
Copy link

I hit an interesting case where Pub's "packages" symlinks get confused. Consider this folder structure:

web_ui/
  example/
 
  test/data/input
    example -> ../../../example

In this case, you end up with a packages symlink like this:

web_ui
  example/
    packages -> ../../../../../../packages

Basically, the number of ".." gets doubled because it's taking into account the relative symlink in "test/data/input"

Probably, you need to normalize the directory path relative to the directory containing the pubspec, before computing the relative symlink path for "packages"

BTW: this is not high priority--I was already in the process of fixing web_ui to not require symlinks to itself for tests. So I can unblock us on the web_ui side.

@munificent
Copy link
Member

Added this to the Later milestone.
Removed Priority-Medium label.
Added Priority-Low label.

@DartBot
Copy link

DartBot commented May 5, 2013

This comment was originally written by [email protected]


Added Community-StarterBug label.

@munificent
Copy link
Member

Marked this as being blocked by #15103.

@munificent
Copy link
Member

Set owner to @munificent.
Added Started label.

@munificent
Copy link
Member

Added Fixed label.

@jmesserly jmesserly added Type-Defect P3 A lower priority bug or feature request labels Jun 12, 2014
@jmesserly jmesserly added this to the Later milestone Jun 12, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#492.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

3 participants