Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncError.error should be typed "dynamic" #7892

Closed
nex3 opened this issue Jan 14, 2013 · 2 comments
Closed

AsyncError.error should be typed "dynamic" #7892

nex3 opened this issue Jan 14, 2013 · 2 comments
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.

Comments

@nex3
Copy link
Member

nex3 commented Jan 14, 2013

Currently AsyncError.error has the type "Object", which causes analyzer warnings when you know the type of the error and try to access properties on it. Typing it "dynamic" would be more accurate.

I think AsyncError.stackTrace should also be typed "dynamic" until issue #142 is fixed.
@lrhn
Copy link
Member

lrhn commented Jan 15, 2013

Agree to changing type of error.
As I read issue #142, keeping stacktrace as Object is actually the right thing.

Set owner to @lrhn.
Added Accepted label.

@lrhn
Copy link
Member

lrhn commented Jan 15, 2013

Added Fixed label.

@nex3 nex3 added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Jan 15, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @lrhn