[Enum Shorthands] Feature specification

[kallentu]

Issue for tracking the status of the feature specification.

The working spec is located here: https://github.com/dart-lang/language/blob/main/working/3616%20-%20enum%20value%20shorthand/proposal-simple-lrhn.md

Work Items

• Enum shorthand design parameters language#4149
• Figure out how the "static access shorthand" feature (a.k.a. "enum shorthands") should handle selector chains and more complex expressions language#4130

[lrhn]

The "simple spec" has been updated with today's decisions.
(Do check that I didn't mess something up.)

[kallentu]

The "simple spec" has been updated with today's decisions. (Do check that I didn't mess something up.)

Just read through it. It looks great and captures what we discussed at today's meeting. Thanks for writing it.

I think with that, we should have everything covered for the spec.
Unless there's something I'm missing.

[lrhn]

I just updated the spec again. Mainly expanding and exemplifying, but I noticed a bug in the constant patterns grammar, where it allowed <staticMemberShorthand> in general.
That's a lot more than the non-shorthand patterns allow, they only allow <qualfiedIdentifier> (which must denote a constant variable) and <constObjectExpression> (which is a constant constructor invocation), with no selectors after.

I changed the constant pattern grammar to only allow shorthands of those two expressions.
(Do check that I did it correctly and didn't forget anything!)

[kallentu]

Looks good. There were a couple of typos - I went ahead and fixed those. Everything else looks great. Thanks for the detailed explanations for the constants section.

I'll continue working on the language tests based on what's written.