Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate linter to new analysis driver. #57610

Closed
pq opened this issue Jul 17, 2017 · 3 comments
Closed

Migrate linter to new analysis driver. #57610

pq opened this issue Jul 17, 2017 · 3 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. devexp-linter Issues with the analyzer's support for the linter package type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@pq
Copy link
Member

pq commented Jul 17, 2017

Specifically, migrate away from use of analysis contexts in analysis.dart.

(Marking as BUG since I take this to be at the heart of missed lints dues to issues w/ error code (re)synthesis.)
@pq pq added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Jul 17, 2017
@pq pq mentioned this issue Jul 17, 2017
Closed
@pq
Copy link
Member Author

pq commented Jul 17, 2017

Maybe a good candidate for using the new AnalysisSession API?

@bwilkerson

@pq
Copy link
Member Author

pq commented Jul 25, 2017

See: #30239

pq referenced this issue in dart-archive/linter Jul 25, 2017
@pq
Update linter to use new driver-based engine (#743).
6521327
@pq pq mentioned this issue Jul 25, 2017
Merged
pq referenced this issue Jul 25, 2017
@pq
Update linter engine to use driver (linter#743).
b72742e 
[email protected], [email protected]

See: https://github.com/dart-lang/linter/issues/743
Review-Url: https://codereview.chromium.org/2992463003 .
pq referenced this issue in dart-archive/linter Jul 27, 2017
@pq
Update linter to use new driver-based engine (#743). (#754)
5b5e368 
* Fix deprecated `getSdkDir` cli_util call.

* Revert "Fix deprecated `getSdkDir` cli_util call."

This reverts commit 829992b.

* Update linter to use new driver-based engine (#743).

* Bump analyzer dep.

* Widened analyzer constraint bounds.
@pq
Copy link
Member Author

pq commented Jul 28, 2017

Done w/ dart-archive/linter#754 and #57616.

@pq pq closed this as completed Jul 28, 2017
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. devexp-linter Issues with the analyzer's support for the linter package type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @devoncarew