Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate checked-in generated files #567

Closed
dgrove opened this issue Nov 23, 2011 · 11 comments
Closed

eliminate checked-in generated files #567

dgrove opened this issue Nov 23, 2011 · 11 comments
Assignees
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@dgrove
Copy link
Contributor

dgrove commented Nov 23, 2011

One thing we learned during today's breakage is that we need to make all generation of dart code part of the build process. These files are checked in auto-generated - can you please either remove these files or move their generation into the standard build process?

dart/client/dom/dom.dart:// Auto-generated Dart DOM library.
dart/client/dom/frog_dom.dart:// Auto-generated Dart DOM library.
dart/client/dom/monkey_dom.dart.broken:// Auto-generated Dart DOM library.
dart/client/dom/wrapping_dom.dart:// Auto-generated Dart DOM library.

@DartBot
Copy link

DartBot commented Nov 24, 2011

This comment was originally written by [email protected]


Added Triaged label.

@dgrove
Copy link
Contributor Author

dgrove commented Dec 20, 2011

Now that all of dartium's files are available on the outside, can this please be addressed soon?

@vsmenon
Copy link
Member

vsmenon commented Mar 26, 2012

Set owner to @vsmenon.
Removed Priority-High label.
Added Priority-Medium label.

@vsmenon
Copy link
Member

vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member

vsmenon commented Jun 22, 2012

Added this to the Later milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

Removed the owner.

@blois
Copy link
Contributor

blois commented Oct 15, 2012

We decided to keep the html_dart2js.dart and html_dartium.dart generated files, but move all intermediate files into the output directory.


Removed this from the Later milestone.
Added this to the M2 milestone.

@efortuna
Copy link
Contributor

Set owner to @efortuna.

@efortuna
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@efortuna
Copy link
Contributor

Fixed with https://codereview.chromium.org//11691009


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

6 participants