-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eliminate checked-in generated files #567
Comments
This comment was originally written by [email protected] Added Triaged label. |
Now that all of dartium's files are available on the outside, can this please be addressed soon? |
Set owner to @vsmenon. |
Added this to the Later milestone. |
Removed the owner. |
Set owner to @efortuna. |
Fixed with https://codereview.chromium.org//11691009 Added Fixed label. |
dgrove
added
Type-Defect
web-libraries
Issues impacting dart:html, etc., libraries
labels
Dec 28, 2012
This was referenced Oct 29, 2020
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One thing we learned during today's breakage is that we need to make all generation of dart code part of the build process. These files are checked in auto-generated - can you please either remove these files or move their generation into the standard build process?
dart/client/dom/dom.dart:// Auto-generated Dart DOM library.
dart/client/dom/frog_dom.dart:// Auto-generated Dart DOM library.
dart/client/dom/monkey_dom.dart.broken:// Auto-generated Dart DOM library.
dart/client/dom/wrapping_dom.dart:// Auto-generated Dart DOM library.
The text was updated successfully, but these errors were encountered: