[CP] Fix crashes due to unhandled StructuralParameterTypes in UP in the CFE

[chloestefantsova]

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/379800

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/380001

Issue Description

The algorithm for computing the standard upper bound of two types, also known as UP, was partially missing its implementation for StructuralParameterType objects. In some corner casing the lacking implementation resulted in a crash of the compiler. All platforms using the CFE were affected.

What is the fix

The fix adds the missing part of the UP algorithm.

Why cherry-pick

The crashes due to the lacking implementation of UP in the CFE were reported by Flutter users: flutter/flutter#152984.

Risk

Low. The update is local and minimal and passes our CQ tests. Moreover, the missing part of the algorithm is implemented via abstracting a similar part of the same algorithm for TypeParameterType objects and applying it to StructuralParameterType objects.

Issue link(s)

flutter/flutter#152984

Extra Info

No response

[dart-github-bot]

Summary: The Dart compiler (CFE) crashed in certain scenarios due to an incomplete implementation of the "upper bound" algorithm for StructuralParameterType objects. The fix completes the algorithm, preventing crashes and ensuring proper type inference.

[itsjustkevin]

@chloestefantsova is this meant for stable? This will land in the next Dart beta branch coming soon, we won’t need to cherry-pick to beta.

[chloestefantsova]

@itsjustkevin I'm not entirely sure. @mraleph requested a CP, and @johnniwinther suggested it should be in beta. I'm happy to recreate the request for stable if needed.

[itsjustkevin]

@mraleph and @johnniwinther i plan to do a beta build this week which will include the fix that landed on main. Does this satisfy the requirements?

[johnniwinther]

Move it to stable. It's satisfactory to have it in the next beta.

[chloestefantsova]

Following the discussion above, I'm closing this request. I've created the CP for stable instead: #56457.