Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfe] Error when omitting base/final/sealed on base/final superclasses through legacy libraries. #52316

Closed
kallentu opened this issue May 9, 2023 · 3 comments
Closed

[cfe] Error when omitting base/final/sealed on base/final superclasses through legacy libraries. #52316

kallentu opened this issue May 9, 2023 · 3 comments
Assignees
@kallentu
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kallentu
Copy link
Member

kallentu commented May 9, 2023

https://github.com/dart-lang/sdk/blob/main/tests/language/class_modifiers/trans_legacy/legacy_superdeclaration_error_test.dart
Missing errors from line 46 and onwards.

The CFE is not reporting an error when a class from a 3.0 library is a subclass of a class in a 2.19 library whose supertype is from the core libraries.
@kallentu kallentu added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label May 9, 2023
@kallentu kallentu self-assigned this May 9, 2023
@kallentu kallentu added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label May 9, 2023
@kallentu kallentu mentioned this issue May 10, 2023
Closed
@kallentu
Copy link
Member Author

Done through https://dart-review.googlesource.com/c/sdk/+/301503.

@kallentu kallentu mentioned this issue May 10, 2023
Closed
@kallentu
Copy link
Member Author

@sgrekhov
versioning_A03_t01.dart - checks that final class cannot be extended
versioning_A03_t04.dart - checks that mixin on a final class cannot be declared

These two should be fixed with this fix.

@sgrekhov
Copy link
Contributor

Yes, now it works. Confirmed. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kallentu kallentu

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @kallentu