Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] Please cherry pick cc80ccfaa0b66a89a04cd07081d9f42bcf3d2bcf to beta #50418

Closed
annagrin opened this issue Nov 9, 2022 · 3 comments
Closed
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. cherry-pick-approved Label for approved cherrypick request merge-to-beta

Comments

@annagrin
Copy link
Contributor

annagrin commented Nov 9, 2022

Commit(s) to merge

cc80ccf

Target

beta, stable

Prepared changelist for beta/stable

https://dart-review.git.corp.google.com/c/sdk/+/268609

Issue Description

Issue

Defining a mixin application in a separate library from the mixin declaration with a private field caused stack overflow during execution.

PlatformsThe issue was caused by and optimization using this to implement calls to super for non-overriden private accessors.
The fix is to disable the optimization inside the bodies of mixin application accessor stubs.

web

What is the fix

The issue was caused by and optimization using this to implement calls to super for non-overridden private accessors.
The fix is to disable the optimization inside the bodies of mixin application accessor stubs.

Why cherry-pick

The issue has caused crashes for users of package:riverpod/riverpod.dart:

Original issue: rrousselGit/riverpod#1713

Risk

low

Issue link(s)

#50119

Extra Info

No response

@annagrin annagrin added the cherry-pick-review Issue that need cherry pick triage to approve label Nov 9, 2022
@a-siva a-siva added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Nov 9, 2022
@sigmundch
Copy link
Member

lgtm

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Nov 9, 2022
@itsjustkevin
Copy link
Contributor

Approved for both beta and stable.

@whesse
Copy link
Contributor

whesse commented Dec 7, 2022

The commit cherry-picked by this request is included in the new beta branch 2.19.0-444.1.beta, and no longer needs to be cherry-picked

@whesse whesse closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. cherry-pick-approved Label for approved cherrypick request merge-to-beta
Projects
None yet
Development

No branches or pull requests

8 participants